[OCTRL-1091] Hostname resolving in environment controller#839
Merged
Conversation
Environment CRD controller needs a way how to resolve hostname passed from ECS to the one existing inside k8s cluster. ECS passes non fully qualified hostname, while kubernetes needs fully qualified hostname
justonedev1
changed the title
knopers8
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing hostname from ECS to the k8s client there were discrepancies between FQDN and just hostname, where k8s needs exact name of the node where Task should run (in k3s this is FQDN of the machine eg.
mtichak-ost.cern.ch) but ECS passes just hostname (eg.mtichak-ost). This code tries find FQDN or tries to resolve the hostname to FQDN and passes it to the tasks, so they can be matched and deployed properly.